ClientFunction - window.location.href returns a wrong URL

[viraxslot]

Hi,

I've written this test case:

const getURL = ClientFunction(() => window.location.href);

test ('test', async t => {
await page1.gotoSecondPage();

await t
	.click(page2.find('span a'))    
	.expect(helloPage().helloWindow.withExactText('hello message'))
	.ok('Hello window is opened');
	
const url = await getURL();
await t.expect(url).eql(helloWindowURL, 'Link is correct');
})
.after (async t => {
	await t.navigateTo(page1);
	await page1.selectElement1();
	await page1.selectElement2();
});

I have 3 pages and links between them are page1 => page2 => helloPage

My intention is checking link which should be opened from second page.
The problem is my test fails sometimes with an error:

AssertionError: Link is correct: expected 'http://page2' to deeply equal 'http://helloPage'

But it's impossible because before link checking I check element on helloPage, so it should be opened already.
I really don't understand why it happens. Do you have any idea?

Btw, on my local machine I can't reproduce this problem.
For remote machine my run command is:
testcafe chrome,opera,firefox -c 2 src/tests -r spec,nunit:results/nunit-results.xml -S -s logs/screenshots

Thank you.

[vastydeep]

Could it be that await t and await getURL() are asynchronous in regard to each other and that sometimes await getURL() completes first?

[viraxslot]

Yeah, I think you're right and this is only one possibility. So I'll remove "await" and rerun my test cases.
I thought because of this it shouldn't go to the next expression.

[vastydeep]

Seems like it should work according to this: http://devexpress.github.io/testcafe/documentation/test-api/obtaining-data-from-the-client.html#executing-client-functions, maybe something else is going on.

[viraxslot]

Well, yeah, I've got this expression from examples in documentation, not from my head.
But, who knows.

UPDATE:
@vastydeep it's interesting, because at the end of this page (behind your link) is written:
You cannot use generators or async/await syntax within client functions.

@MarinaRukavitsyna could you help us?

[MarinaRukavitsyna]

Hi guys,
It is difficult to determine the cause of issue without reproducing it locally. It looks like the getURL() method returns a wrong link for some reason.

@viraxslot,
Would you please provide us with a link to the problematic page so that we can see the issue locally? If you do not want to share your web site with other users, you can send a private message to me.

[viraxslot]

@MarinaRukavitsyna it's a pity, but I can't share it even in private messages. So, maybe I can add some debug information which could help you to understand what's going on? Just tell me what to do

And... can I use "await" with Client Function? I think it's a little contradiction in the documentation so I didn't understand this point.

[MarinaRukavitsyna]

@viraxslot
Just a follow-up, your ".expect(helloPage())" assertion looks incorrect as it always passes. Please modify it as shown below:

expect(helloPage().helloWindow.withExactText('hello message').exists)
 .ok('Hello window is opened');

[MarinaRukavitsyna]

Please add t.debug() and console.log to check the URL.

can I use "await" with Client Function?

It is not possible to use "await" inside ClientFunction. But, you need to call it with the await keyword to execute a client function. So, your original ClientFunction code is correct.